[Mlir-commits] [mlir] [mlir][spirv] Add Pooling, Fourier Transform, and MatMul operations t… (PR #177585)

[Davide Grohmann]

================
@@ -132,6 +157,37 @@ LogicalResult TosaDepthwiseConv2DOp::verify() {
   return verifyConvOp(this->getOperation(), inputETy, resultETy, accType);
 }
 
+//===----------------------------------------------------------------------===//
+// spirv.TosaMatMulOp
+//===----------------------------------------------------------------------===//
+
+LogicalResult TosaMatMulOp::verify() {
----------------
davidegrohmann wrote:

We cannot check that the zero point are 0 since they are coming from an `spirv::Constant` op and we said in earlier reviews that verifier cannot look into other ops to do their work. (That is why those checks have been removed from Conv ops as well.)

Since they are always required in the SPIRV assembly, perhaps it is easier to have zero as default value which can be overwritten if needed?

https://github.com/llvm/llvm-project/pull/177585