[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of visitNonControlFlowArguments (PR #175210)

[Matthias Springer]

================
@@ -215,8 +215,8 @@ class AbstractSparseForwardDataFlowAnalysis : public DataFlowAnalysis {
   /// of loops).
   virtual void visitNonControlFlowArgumentsImpl(
       Operation *op, const RegionSuccessor &successor,
-      ValueRange successorInputs, ArrayRef<AbstractSparseLattice *> argLattices,
-      unsigned firstIndex) = 0;
+      ValueRange nonSuccessorInputs,
+      ArrayRef<AbstractSparseLattice *> nonSuccessorInputLattices) = 0;
----------------
matthias-springer wrote:

Oh wait! I'm getting confused. Are the lattices here actually the non-successor-input lattices or all lattices? Can you double check? (We had a similar discussion here: https://github.com/llvm/llvm-project/pull/175210#discussion_r2725798475)

(I believe the API should be such that we only pass the non-successor-input lattices. But then the implementation in the code snippet mention above would be wrong?)



https://github.com/llvm/llvm-project/pull/175210