[Mlir-commits] [mlir] [mlir][analysis] Cleanup collectUnderlyingAddressValues (NFC) (PR #177905)

[lonely eagle]

https://github.com/linuxlonelyeagle updated https://github.com/llvm/llvm-project/pull/177905

>From ada1a581d694aee196ffe5192a2d65c1cee064e3 Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Mon, 26 Jan 2026 07:57:22 +0000
Subject: [PATCH 1/2] cleanup collectUnderlyingAddressValues.

---
 mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
index b698756dd75e9..ff37483c77c8b 100644
--- a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
+++ b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
@@ -170,17 +170,15 @@ static void collectUnderlyingAddressValues(BlockArgument arg, unsigned maxDepth,
     // the entry block.
     SmallVector<RegionSuccessor> successors;
     branch.getSuccessorRegions(RegionBranchPoint::parent(), successors);
-    RegionSuccessor regionSuccessor(region);
-    bool found = false;
+    RegionSuccessor regionSuccessor = RegionSuccessor::parent();
     for (RegionSuccessor &successor : successors) {
       if (successor.getSuccessor() == region) {
         LDBG() << "  Found matching region successor: " << successor;
-        found = true;
         regionSuccessor = successor;
         break;
       }
     }
-    if (!found) {
+    if (regionSuccessor.isParent()) {
       LDBG()
           << "  No matching region successor found, adding argument to output";
       output.push_back(arg);

>From 0b8a45d537301dd52ad446ab4c4af71a58f51c07 Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Mon, 26 Jan 2026 08:32:25 +0000
Subject: [PATCH 2/2] update code.

---
 .../AliasAnalysis/LocalAliasAnalysis.cpp         | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
index ff37483c77c8b..5a4679ef31422 100644
--- a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
+++ b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
@@ -170,22 +170,16 @@ static void collectUnderlyingAddressValues(BlockArgument arg, unsigned maxDepth,
     // the entry block.
     SmallVector<RegionSuccessor> successors;
     branch.getSuccessorRegions(RegionBranchPoint::parent(), successors);
-    RegionSuccessor regionSuccessor = RegionSuccessor::parent();
     for (RegionSuccessor &successor : successors) {
       if (successor.getSuccessor() == region) {
         LDBG() << "  Found matching region successor: " << successor;
-        regionSuccessor = successor;
-        break;
+        return collectUnderlyingAddressValues2(
+            branch, successor, arg, argNumber, maxDepth, visited, output);
       }
     }
-    if (regionSuccessor.isParent()) {
-      LDBG()
-          << "  No matching region successor found, adding argument to output";
-      output.push_back(arg);
-      return;
-    }
-    return collectUnderlyingAddressValues2(
-        branch, regionSuccessor, arg, argNumber, maxDepth, visited, output);
+    LDBG() << "  No matching region successor found, adding argument to output";
+    output.push_back(arg);
+    return;
   }
 
   LDBG()