[Mlir-commits] [mlir] [MLIR][Python] Add a DSL for defining dialects in Python bindings (PR #169045)

[Maksim Levental]

================
@@ -957,7 +957,7 @@ class MLIR_PYTHON_API_EXPORTED PyConcreteType : public BaseTy {
   }
 
   static void bind(nanobind::module_ &m) {
-    auto cls = ClassTy(m, DerivedTy::pyClassName);
+    auto cls = ClassTy(m, DerivedTy::pyClassName, nanobind::is_generic());
----------------
makslevental wrote:

umm why are we doing this? this CRTP is exactly the opposite of generic? it's "concrete" - each of the instantiations generally isn't paramterized in a clearly generic way - e.g. what is the "genericism" of `IntegerType` or `FloatType`?

https://github.com/llvm/llvm-project/pull/169045