[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of old visitNonControlFlowArguments, add new visitNonControlFlowArguments API and use it in IntegerRangeAnalysis (PR #175210)

[lonely eagle]

================
@@ -325,16 +332,21 @@ class SparseForwardDataFlowAnalysis
   /// operands, and a region successor, compute the lattice values for block
   /// arguments that are not accounted for by the branching control flow (ex.
   /// the bounds of loops). By default, this method marks all such lattice
-  /// elements as having reached a pessimistic fixpoint. `firstIndex` is the
-  /// index of the first element of `argLattices` that is set by control-flow.
+  /// elements as having reached a pessimistic fixpoint.
   virtual void visitNonControlFlowArguments(Operation *op,
----------------
linuxlonelyeagle wrote:

* Can this Operation * be changed to RegionBranchOpInterface.
Yes.
* I am also wondering about the name of the function: "nonControlFlowArguments" is inconsistent with the naming in the region branch op interface. Should this function be called visitNonSuccessorInputs?
Yes.
* I think this can be called for both block arguments and op results, which makes the current name of the function even worse.
Yes.


https://github.com/llvm/llvm-project/pull/175210