[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of old visitNonControlFlowArguments, add new visitNonControlFlowArguments API and use it in IntegerRangeAnalysis (PR #175210)

[Matthias Springer]

================
@@ -325,16 +332,21 @@ class SparseForwardDataFlowAnalysis
   /// operands, and a region successor, compute the lattice values for block
   /// arguments that are not accounted for by the branching control flow (ex.
   /// the bounds of loops). By default, this method marks all such lattice
-  /// elements as having reached a pessimistic fixpoint. `firstIndex` is the
-  /// index of the first element of `argLattices` that is set by control-flow.
+  /// elements as having reached a pessimistic fixpoint.
   virtual void visitNonControlFlowArguments(Operation *op,
----------------
matthias-springer wrote:

- Can this `Operation *` be changed to `RegionBranchOpInterface`.
- I am also wondering about the name of the function: "nonControlFlowArguments" is inconsistent with the naming in the region branch op interface. Should this function be called `visitNonSuccessorInputs`?
- Is this function only called for block arguments or also for op results? (In the latter case, how are non-successor-input op results handled?)

https://github.com/llvm/llvm-project/pull/175210