[Mlir-commits] [mlir] Cleanup: Remove SmallVector hacks (PR #177667)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-llvm

Author: AZero13 (AZero13)

<details>
<summary>Changes</summary>

We no longer support any platform that uses Clang 5. This was a workaround for older clang versions where template arguments weren't merged between forward declarations and definitions correctly.

Since we don't support anything this old anymore, we can drop this workaround.

---
Full diff: https://github.com/llvm/llvm-project/pull/177667.diff


1 Files Affected:

- (modified) mlir/include/mlir/Support/LLVM.h (-8) 


``````````diff
diff --git a/mlir/include/mlir/Support/LLVM.h b/mlir/include/mlir/Support/LLVM.h
index 020c0fba726c8..81bbd717c4f80 100644
--- a/mlir/include/mlir/Support/LLVM.h
+++ b/mlir/include/mlir/Support/LLVM.h
@@ -26,14 +26,6 @@
 // it anyway.
 #include "llvm/Support/LogicalResult.h"
 
-// Workaround for clang-5 (PR41549)
-#if defined(__clang_major__)
-#if __clang_major__ <= 5
-#include "llvm/ADT/DenseMapInfo.h"
-#include "llvm/ADT/SmallVector.h"
-#endif
-#endif
-
 // Forward declarations.
 namespace llvm {
 // String types

``````````

</details>


https://github.com/llvm/llvm-project/pull/177667