[Mlir-commits] [mlir] [mlir][python][NFC] Make pybind references consistent with current bindings (PR #175528)

Vitalii Shutov llvmlistbot at llvm.org
Fri Jan 23 09:47:17 PST 2026


================
@@ -663,7 +659,7 @@ class mlir_type_subclass : public pure_subclass {
       // 'get_static_typeid' method.
       // This is modeled as a static method instead of a static property because
       // `def_property_readonly_static` is not available in `pure_subclass` and
-      // we do not want to introduce additional complexity to implement it.
+      // we do not want to implement a custom descriptor to emulate it.
----------------
Lallapallooza wrote:

ack, I used "descriptor" as shorthand for the Python mechanism behind a static property. I'll drop it and revert the comment to stay consistent with the rest of the bindings.

For reference only: Python's docs explicitly call the mechanism behind properties/staticmethods/classmethods "descriptors" https://docs.python.org/3/howto/descriptor.html.

https://github.com/llvm/llvm-project/pull/175528


More information about the Mlir-commits mailing list