[Mlir-commits] [mlir] [mlir][python][NFC] Make pybind references consistent with current bindings (PR #175528)

Maksim Levental llvmlistbot at llvm.org
Fri Jan 23 09:21:15 PST 2026


================
@@ -663,7 +659,7 @@ class mlir_type_subclass : public pure_subclass {
       // 'get_static_typeid' method.
       // This is modeled as a static method instead of a static property because
       // `def_property_readonly_static` is not available in `pure_subclass` and
-      // we do not want to introduce additional complexity to implement it.
+      // we do not want to implement a custom descriptor to emulate it.
----------------
makslevental wrote:

nit: i'm not sure why you're taking liberty with these things. "descriptor" is not a word we use anywhere around in either code or the comments and as far as i know there's not "descriptor"-like about these patterns.

https://github.com/llvm/llvm-project/pull/175528


More information about the Mlir-commits mailing list