[Mlir-commits] [mlir] [mlir][tosa] Add constant folding for tosa.add_shape operation (PR #173112)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Dialect/Tosa/CMakeFiles/obj.MLIRTosaDialect.dir/IR/TosaCanonicalizations.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Dialect/Tosa/CMakeFiles/obj.MLIRTosaDialect.dir/IR/TosaCanonicalizations.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\lib\Dialect\Tosa -IC:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa -Itools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -MD -UNDEBUG /EHs-c- /GR- -std:c++17 /showIncludes /Fotools\mlir\lib\Dialect\Tosa\CMakeFiles\obj.MLIRTosaDialect.dir\IR\TosaCanonicalizations.cpp.obj /Fdtools\mlir\lib\Dialect\Tosa\CMakeFiles\obj.MLIRTosaDialect.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp(1713,23): error: unknown type name 'AddFoldAdaptor'; did you mean 'FoldAdaptor'?
1713 |   return binaryFolder<AddFoldAdaptor>(
|                       ^~~~~~~~~~~~~~
|                       FoldAdaptor
tools\mlir\include\mlir/Dialect/Tosa/IR/TosaOps.h.inc(1446,9): note: 'FoldAdaptor' declared here
1446 |   using FoldAdaptor = GenericAdaptor<::llvm::ArrayRef<::mlir::Attribute>>;
|         ^
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp(908,40): error: no member named 'fold' in 'mlir::tosa::AddShapeOpGenericAdaptor<llvm::ArrayRef<mlir::Attribute>>'
908 |       const auto maybeResult = Folder::fold(l, r);
|                                ~~~~~~~~^
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp(1713,10): note: in instantiation of function template specialization 'binaryFolder<mlir::tosa::AddShapeOpGenericAdaptor<llvm::ArrayRef<mlir::Attribute>>>' requested here
1713 |   return binaryFolder<AddFoldAdaptor>(
|          ^
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp(917,40): error: no member named 'fold' in 'mlir::tosa::AddShapeOpGenericAdaptor<llvm::ArrayRef<mlir::Attribute>>'
917 |       const auto maybeResult = Folder::fold(l, r, lIntTy.isUnsigned());
|                                ~~~~~~~~^
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Tosa\IR\TosaCanonicalizations.cpp(928,40): error: no member named 'fold' in 'mlir::tosa::AddShapeOpGenericAdaptor<llvm::ArrayRef<mlir::Attribute>>'
928 |       const auto maybeResult = Folder::fold(l, r, false);
|                                ~~~~~~~~^
4 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/173112