[Mlir-commits] [mlir] [Linalg] Update Vectorization to work with both named as well as generic conv ops (PR #176339)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Overall LGTM, I really like how non-intrusive the changes in tests are, thanks 🙏🏻 

Let me quickly note that, at least at the high level, we discussed this approach in https://github.com/llvm/llvm-project/pull/174196 (*). I mean specifically making a transformation to match both `ConvOp` and `GenericOp` (combined with specialisation).

High level question - does this PR change the vectorization of `linalg.generic` Ops that implement some `ConvOp`? IIUC, before this change such `GenericOp`s would be vectorized via: https://github.com/llvm/llvm-project/blob/d265996cc6203a7288f10d8760c0ddbb35f502bd/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp?plain=1#L2778

Thanks!

https://github.com/llvm/llvm-project/pull/176339