[Mlir-commits] [mlir] [MLIR][NVVM] Add binaryCallback (PR #170853)

[Mehdi Amini]

================
@@ -521,6 +524,15 @@ NVPTXSerializer::compileToBinary(const std::string &ptxCode) {
                                                 /*ErrMsg=*/&message))
     return emitLogError("`fatbinary`");
 
+  if (binaryCallback) {
+    llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> logBuffer =
+        llvm::MemoryBuffer::getFile(logFile->first);
+    if (logBuffer && !(*logBuffer)->getBuffer().empty()) {
+      StringRef logRef = (*logBuffer)->getBuffer();
+      binaryCallback(logRef);
----------------
joker-eph wrote:

> ptxas also emits warnings, and info diagnostics, packing them as remark isn't great.

Why isn't it great?

https://github.com/llvm/llvm-project/pull/170853