[Mlir-commits] [mlir] [MLIR][XeGPU] setUnitDim bug fix and add documentation (PR #173521)

[Jianhui Li]

Jianhui-Li wrote:

> Approving to unblock.
> 
> `mapSlicedDimsToParentSpace` is still not very clear to me. please address the comments.
> 
> nit: Passing the correct parent rank will make this function a lot more straightforward.

Passing the parent rank is not required.  It is a tradeoff between complexity on user code vs. the function implementation. The user code is recursive so asking user to provide parent rank is also confusing. 

https://github.com/llvm/llvm-project/pull/173521