[Mlir-commits] [mlir] [mlir] Speed up resolving ExtractValueOp source (PR #176478)

[llvmlistbot at llvm.org]

neildhar wrote:

Thanks for the review @matthias-springer and @gysit!

> can you confirm that this pattern produces the exact same IR as the existing folder

Yes, the new pattern is just a subset of the existing folder. If the folder runs first, the pattern will not do anything. If the folder runs last, it will just finish resolving from where the pattern left off.

> if we can have the walking logic in one place to make things faster & easier to maintain in one go.

That was my initial intention, and I agree that would be great. But I haven't been able to come up with a way that to do it that is simpler than what we currently have. Most of the code in the folder traversal is for handling the various cases of full and partial overlap, but the version in the pattern doesn't do this right now, it just leaves it for the folder.

https://github.com/llvm/llvm-project/pull/176478