[Mlir-commits] [mlir] [mlir] Speed up resolving ExtractValueOp source (PR #176478)

[Tobias Gysi]

gysit wrote:

@neildhar can you quantify the performance difference you saw on you example. I understand this pattern is beneficial in some cases, but at the same time it also needs to build the map etc. So it maybe great to get a bit more insights from your use case. 

I like your suggestion on the other PR to remove the insert op chain walk from the folder and do it entirely in the canonicalization pattern. That would leave the folder with folding to a constant etc while the canonicalization pattern would do the walk without code duplication between folder and pattern.


https://github.com/llvm/llvm-project/pull/176478