[Mlir-commits] [mlir] [mlir] Always update ExtractValue to use last container in insert chain (PR #176588)

[Tobias Gysi]

gysit wrote:

> My thinking is that if https://github.com/llvm/llvm-project/pull/176478 is accepted, it may make sense to only handle the cases that the new InsertValueOp canonicalizer will not handle. That should cut down on most of the traversal here. But as long as the traversal is done top-down, it may not matter much in the common case.

Yes that could make sense. Basically fold to a constant here and use a canonicalization pattern for the walk. That way we don't duplicate that walking logic.

https://github.com/llvm/llvm-project/pull/176588