[Mlir-commits] [mlir] [mlir][vscode] Fix PDLL grammar character class regex (PR #176601)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Jacques Pienaar (jpienaar)

<details>
<summary>Changes</summary>

The character class [aA-zZ_0-9] incorrectly matches characters between ASCII 90-97 (Z-a range), which includes: [ \ ] ^ _ `. This should be [a-zA-Z_0-9] for proper identifier matching.

---
Full diff: https://github.com/llvm/llvm-project/pull/176601.diff


1 Files Affected:

- (modified) mlir/utils/vscode/pdll-grammar.json (+8-8) 


``````````diff
diff --git a/mlir/utils/vscode/pdll-grammar.json b/mlir/utils/vscode/pdll-grammar.json
index 47c8968c3ac0c..308a250f352e5 100644
--- a/mlir/utils/vscode/pdll-grammar.json
+++ b/mlir/utils/vscode/pdll-grammar.json
@@ -102,7 +102,7 @@
     "argument_or_result_list": {
       "patterns": [
         {
-          "match": "\\b([aA-zZ_0-9]*)\\b\\s*:\\s*([aA-zZ_0-9]+)\\b(\\<([^\\>]+)\\>)?",
+          "match": "\\b([a-zA-Z_0-9]*)\\b\\s*:\\s*([a-zA-Z_0-9]+)\\b(\\<([^\\>]+)\\>)?",
           "captures": {
             "1": {
               "name": "variable.parameter.pdll"
@@ -116,7 +116,7 @@
           }
         },
         {
-          "match": "(\\(|\\>|,)\\s*([aA-zZ_0-9]+)\\b(\\<([^\\>]+)\\>)?\\s*(?=[^:])",
+          "match": "(\\(|\\>|,)\\s*([a-zA-Z_0-9]+)\\b(\\<([^\\>]+)\\>)?\\s*(?=[^:])",
           "captures": {
             "2": {
               "name": "entity.name.type.pdll"
@@ -131,7 +131,7 @@
     "user_constraint": {
       "patterns": [
         {
-          "begin": "\\b(Constraint)\\b\\s*(\\b[aA-zZ_0-9]*\\b)?",
+          "begin": "\\b(Constraint)\\b\\s*(\\b[a-zA-Z_0-9]*\\b)?",
           "beginCaptures": {
             "1": {
               "name": "keyword.other.pdll"
@@ -188,7 +188,7 @@
     "user_rewrite": {
       "patterns": [
         {
-          "begin": "\\b(Rewrite)\\b\\s*(\\b[aA-zZ_0-9]*\\b)?",
+          "begin": "\\b(Rewrite)\\b\\s*(\\b[a-zA-Z_0-9]*\\b)?",
           "beginCaptures": {
             "1": {
               "name": "keyword.other.pdll"
@@ -268,7 +268,7 @@
     "pattern": {
       "patterns": [
         {
-          "begin": "\\b(Pattern)\\b\\s*(\\b[aA-zZ_0-9]*\\b)?\\s*(\\bwith\\b\\s*[^\\{]*)?\\s*({)",
+          "begin": "\\b(Pattern)\\b\\s*(\\b[a-zA-Z_0-9]*\\b)?\\s*(\\bwith\\b\\s*[^\\{]*)?\\s*({)",
           "beginCaptures": {
             "1": {
               "name": "keyword.other.pdll"
@@ -292,7 +292,7 @@
           "end": "(})"
         },
         {
-          "begin": "\\b(Pattern)\\b\\s*(\\b[aA-zZ_0-9]*\\b)?\\s*(\\bwith\\b\\s*[^\\=]*)?\\s*(=>)",
+          "begin": "\\b(Pattern)\\b\\s*(\\b[a-zA-Z_0-9]*\\b)?\\s*(\\bwith\\b\\s*[^\\=]*)?\\s*(=>)",
           "beginCaptures": {
             "1": {
               "name": "keyword.other.pdll"
@@ -363,7 +363,7 @@
     "variable_definition": {
       "patterns": [
         {
-          "begin": "\\b([aA-zZ_0-9]*)\\b\\s*:\\s*\\[",
+          "begin": "\\b([a-zA-Z_0-9]*)\\b\\s*:\\s*\\[",
           "beginCaptures": {
             "1": {
               "name": "entity.name.variable.pdll"
@@ -377,7 +377,7 @@
           "end": "\\]"
         },
         {
-          "match": "\\b([aA-zZ_0-9]*)\\b\\s*:\\s*([aA-zZ_0-9]+(\\<([^\\>]+)\\>)?)",
+          "match": "\\b([a-zA-Z_0-9]*)\\b\\s*:\\s*([a-zA-Z_0-9]+(\\<([^\\>]+)\\>)?)",
           "captures": {
             "1": {
               "name": "entity.name.variable.pdll"

``````````

</details>


https://github.com/llvm/llvm-project/pull/176601