[Mlir-commits] [mlir] [mlir][math] Add vector support for math-to-apfloat (PR #172715)

[Jan Patrick Lehr]

jplehr wrote:

I think this commit broke one of our bots. The bot does not listen to MLIR changes (apologies, I'll make it listen) so it did only break after this patch found its way into `main`.

Seems like a missing link dependency.

Bot: https://lab.llvm.org/buildbot/#/builders/206/builds/12012/steps/7/logs/stdio

Error
```
[6397/8429] Linking CXX shared library lib/libMLIRArithAndMathToAPFloatUtils.so.23.0git
FAILED: lib/libMLIRArithAndMathToAPFloatUtils.so.23.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Wno-unused-but-set-parameter -Wno-deprecated-copy -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libMLIRArithAndMathToAPFloatUtils.so.23.0git -o lib/libMLIRArithAndMathToAPFloatUtils.so.23.0git tools/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeFiles/obj.MLIRArithAndMathToAPFloatUtils.dir/Utils.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/hip-third-party-libs-test/build/lib:"  lib/libMLIRArithDialect.so.23.0git  lib/libMLIRCastInterfaces.so.23.0git  lib/libMLIRDialect.so.23.0git  lib/libMLIRInferIntRangeCommon.so.23.0git  lib/libMLIRShapedOpInterfaces.so.23.0git  lib/libMLIRInferIntRangeInterface.so.23.0git  lib/libMLIRInferTypeOpInterface.so.23.0git  lib/libMLIRUBDialect.so.23.0git  lib/libMLIRIR.so.23.0git  lib/libMLIRSupport.so.23.0git  lib/libLLVMSupport.so.23.0git  -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/lib && :
/usr/bin/ld: tools/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeFiles/obj.MLIRArithAndMathToAPFloatUtils.dir/Utils.cpp.o: in function `mlir::forEachScalarValue(mlir::RewriterBase&, mlir::Location, mlir::Value, mlir::Value, mlir::Type, llvm::function_ref<mlir::Value (mlir::Value, mlir::Value, mlir::Type)>)':
Utils.cpp:(.text._ZN4mlir18forEachScalarValueERNS_12RewriterBaseENS_8LocationENS_5ValueES3_NS_4TypeEN4llvm12function_refIFS3_S3_S3_S4_EEE+0xe7): undefined reference to `mlir::vector::ToElementsOp::create(mlir::OpBuilder&, mlir::Location, mlir::Value)'
/usr/bin/ld: Utils.cpp:(.text._ZN4mlir18forEachScalarValueERNS_12RewriterBaseENS_8LocationENS_5ValueES3_NS_4TypeEN4llvm12function_refIFS3_S3_S3_S4_EEE+0x136): undefined reference to `mlir::vector::ToElementsOp::create(mlir::OpBuilder&, mlir::Location, mlir::Value)'
/usr/bin/ld: Utils.cpp:(.text._ZN4mlir18forEachScalarValueERNS_12RewriterBaseENS_8LocationENS_5ValueES3_NS_4TypeEN4llvm12function_refIFS3_S3_S3_S4_EEE+0x249): undefined reference to `mlir::vector::ToElementsOp::create(mlir::OpBuilder&, mlir::Location, mlir::Value)'
/usr/bin/ld: Utils.cpp:(.text._ZN4mlir18forEachScalarValueERNS_12RewriterBaseENS_8LocationENS_5ValueES3_NS_4TypeEN4llvm12function_refIFS3_S3_S3_S4_EEE+0x486): undefined reference to `mlir::vector::FromElementsOp::create(mlir::OpBuilder&, mlir::Location, mlir::Type, mlir::ValueRange)'
collect2: error: ld returned 1 exit status
```

https://github.com/llvm/llvm-project/pull/172715