[Mlir-commits] [clang] [flang] [llvm] [mlir] [polly] [CMake][LLVM] Add PCH infrastructure and LLVMSupport PCH (PR #176420)

[Alexis Engelke]

================
@@ -13,6 +13,14 @@ add_flang_library(flangFrontend
   TextDiagnosticBuffer.cpp
   TextDiagnostic.cpp
 
+  DISABLE_PCH_REUSE
+  PRECOMPILE_HEADERS
+  [["flang/Parser/parsing.h"]]
+  [["flang/Parser/parse-tree.h"]]
+  [["flang/Parser/dump-parse-tree.h"]]
+  [["flang/Lower/PFTBuilder.h"]]
+  [["flang/Lower/Bridge.h"]]
----------------
aengelke wrote:

The arguments must be strings that go after the `#include`, so must be quoted (or use angle brackets, but that'd be against LLVM's code style). Now we could write a quoted string with escapes (`"\"flang/....h\""`), but [bracket arguments](https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#bracket-argument) are a more readable alternative since CMake 3.0.

https://github.com/llvm/llvm-project/pull/176420