[Mlir-commits] [mlir] [mlir][scf] Skip ops having results with warning in forall-to-for pass (PR #175926)

[Prathamesh Tagore]

================
@@ -30,6 +30,12 @@ mlir::scf::forallToForLoop(RewriterBase &rewriter, scf::ForallOp forallOp,
   OpBuilder::InsertionGuard guard(rewriter);
   rewriter.setInsertionPoint(forallOp);
 
+  if (!forallOp.getOutputs().empty()) {
+    forallOp.emitWarning()
+        << "skipping scf.forall with outputs, currently not supported";
+    return success();
----------------
meshtag wrote:

That would be a hard failure and we will not lower supported `forall` ops (which the pass intends to work on) in the same region. I modified the test to make this more explicit.

https://github.com/llvm/llvm-project/pull/175926