[Mlir-commits] [clang] [flang] [mlir] [mlir][Interfaces] Split successor inputs from region successor (PR #175815)

[Matthias Springer]

================
@@ -316,19 +315,17 @@ void AbstractSparseForwardDataFlowAnalysis::visitRegionSuccessors(
         if (!inputs.empty())
           firstIndex = cast<OpResult>(inputs.front()).getResultNumber();
         visitNonControlFlowArgumentsImpl(
-            branch,
-            RegionSuccessor::parent(
-                branch->getResults().slice(firstIndex, inputs.size())),
-            lattices, firstIndex);
+            branch, RegionSuccessor::parent(),
+            branch->getResults().slice(firstIndex, inputs.size()), lattices,
----------------
matthias-springer wrote:

Maybe. I am trying to do that here: https://github.com/llvm/llvm-project/pull/175978. But I don't know that part of the code base well enough to make sure that that's safe.

This PR is already large enough, so I wanted to limit the changes to the "mechanical" ones, for which we can for sure say that they are correct. Then improve that API (and maybe others) in a follow-up commit.

https://github.com/llvm/llvm-project/pull/175815