[Mlir-commits] [mlir] [ROCDL] Refactored MFMA ops in ODS; added constraints (PR #175775)

[Ravil Dorozhinskii]

================
@@ -610,11 +610,34 @@ def ROCDL_IglpOpt : ROCDL_ConcreteNonMemIntrOp<"iglp.opt", [], 0, [0], ["variant
 //===---------------------------------------------------------------------===//
 // Xdlops intrinsics
 
-class ROCDL_Mfma_IntrOp<string mnemonic, list<Trait> traits = []> :
-  ROCDL_IntrOp<mnemonic, [], [], traits, 1>,
-  Arguments<(ins Variadic<LLVM_Type>:$args)> {
-  let assemblyFormat =
-    "$args attr-dict `:` functional-type($args, $res)";
+class ROCDL_Mfma_IntrOp<string mnemonic, Type AB, Type CD> :
+  ROCDL_IntrOp<mnemonic, [], [], [], 1, 0, 0, 0, [3, 4, 5], ["cbsz", "abid", "blgp"]>,
+  Arguments<(ins
+             LLVM_ScalarOrVectorOf<AB>:$a,
----------------
ravil-mobile wrote:

Thanks @krzysz00. Do you want to replace ... with concrete definitions of `ROCDL_ConcreteVector` or just use `LLVM_VectorOf` instead of `LLVM_ScalarOrVectorOf` ?

PS The latest update put constrains to all MFMA ops (both `mfma`, `scale_mfma` and `smfmac`). 

https://github.com/llvm/llvm-project/pull/175775