[Mlir-commits] [mlir] 14e97d6 - [mlir][Shape] Fix Yoda condition in OutlineShapeComputation (#174146)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jan 12 05:56:19 PST 2026


Author: Nick Kreeger
Date: 2026-01-12T17:56:15+04:00
New Revision: 14e97d649b72a404ab3d2738dca58708dd2a23f3

URL: https://github.com/llvm/llvm-project/commit/14e97d649b72a404ab3d2738dca58708dd2a23f3
DIFF: https://github.com/llvm/llvm-project/commit/14e97d649b72a404ab3d2738dca58708dd2a23f3.diff

LOG: [mlir][Shape] Fix Yoda condition in OutlineShapeComputation (#174146)

Change `nullptr != inpDefOp` to `inpDefOp != nullptr` for better
readability and consistency with LLVM coding standards.

Added: 
    

Modified: 
    mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
index b6367977b2b9d..650a2396576fd 100644
--- a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
+++ b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
@@ -290,7 +290,7 @@ void OutlineShapeComputationPass::getClusterFromValue(
       cluster.insert(op);
       for (Value inp : op->getOperands()) {
         Operation *inpDefOp = inp.getDefiningOp();
-        if (nullptr != inpDefOp && visited.insert(inpDefOp).second)
+        if (inpDefOp != nullptr && visited.insert(inpDefOp).second)
           queue.push(inpDefOp);
       }
     }


        


More information about the Mlir-commits mailing list