[Mlir-commits] [mlir] [mlir][Python] fix dialect extensions which bind C types (PR #175405)

[llvmlistbot at llvm.org]

================
@@ -45,33 +55,38 @@ InferConvolutionDimensions(MlirOperation op) {
     return std::nullopt;
   }
 
-  return dims;
+  return PyLinalgConvolutionDimensions{
+      dims.batch,        dims.outputImage, dims.outputChannel, dims.filterLoop,
+      dims.inputChannel, dims.depth,       dims.strides,       dims.dilations};
 }
 
 static void populateDialectLinalgSubmodule(nb::module_ m) {
   m.def(
       "fill_builtin_region",
-      [](MlirOperation op) { mlirLinalgFillBuiltinNamedOpRegion(op); },
+      [](PyOperationBase &op) {
+        mlirLinalgFillBuiltinNamedOpRegion(op.getOperation());
+      },
       nb::arg("op"),
       "Fill the region for `op`, which is assumed to be a builtin named Linalg "
       "op.");
 
-  m.def("isa_contraction_op", &mlirLinalgIsAContractionOp,
-        "Checks if the given operation is a Linalg contraction operation.",
-        nb::arg("op"));
+  m.def(
+      "isa_contraction_op",
----------------
PragmaTwice wrote:

not related to this PR: hmm this API seems not so pythonic :rofl:

https://github.com/llvm/llvm-project/pull/175405