[Mlir-commits] [mlir] [mlir][math] Add vector support for math-to-apfloat (PR #172715)

[Matthias Springer]

matthias-springer wrote:

> My one concern is that you're storing `ArrayRef`, which will have lifetime issues - I'd copy those into a `SmallVector` instead

Either that or document somewhere (pattern constructor?) that the lifetime of `ArrayRef` must last at least until the last pattern application. (As long as we don't expose these patterns through public `populate...` functions, I think the current implementation is safe.)


https://github.com/llvm/llvm-project/pull/172715