[Mlir-commits] [mlir] [MLIR][Python] Add a DSL for defining dialects in Python bindings (PR #169045)

[Sasha Lopoukhine]

superlopuh wrote:

This looks great. The only thing to consider is that it's possible that you might want a constraint that is not a type. In xDSL, we used `Annotated` to lift values to types, and introspected that, but it was not very approcahbe, quite difficult to reason about, and had a few issues with "correctness" with respect to Python's typing mechanisms, when using variables. This might be worth considering for your approach too, how you would express "all operands and results of this op have the same type".

https://github.com/llvm/llvm-project/pull/169045