[Mlir-commits] [mlir] [mlir][linalg] Preserve cast semantics during generic to matmul (PR #174757)

[Andrzej Warzyński]

banach-space wrote:

Thanks for the updates!

> I haven't checked this. I'd prefer only dealing with matmul-like ops in this PR though. We can deal with other ops separately if that's fine.

Sure, but please leave a TODO somewhere, eg the summary. Will you look into it? No worries if not, I can take a look myself.

> Please feel free to let me know if more things are required there.

Ultra nit - move the new tests next to other tests for matmul ops, e.g (ie cluster them together):

https://github.com/llvm/llvm-project/blob/eec258dcf38d527cf23cb4c30af63446b1074c8d/mlir/test/Dialect/Linalg/specialize-generic-ops.mlir#L44

Ultra nit - add a block comment, eg: https://github.com/llvm/llvm-project/blob/eec258dcf38d527cf23cb4c30af63446b1074c8d/mlir/test/Dialect/Linalg/vectorization/linalg-ops-with-patterns.mlir#L3

This is just for a bit better testing hygiene :) 

Thanks!


https://github.com/llvm/llvm-project/pull/174757