[Mlir-commits] [mlir] a39f617 - [mlir][dataflow] Use successor.isParent to replace successor.getSuccessor (NFC) (#174615)

[llvmlistbot at llvm.org]

Author: lonely eagle
Date: 2026-01-09T14:04:10+08:00
New Revision: a39f6176af14d8a1360f2b77d6d0e2d4be841fc4

URL: https://github.com/llvm/llvm-project/commit/a39f6176af14d8a1360f2b77d6d0e2d4be841fc4
DIFF: https://github.com/llvm/llvm-project/commit/a39f6176af14d8a1360f2b77d6d0e2d4be841fc4.diff

LOG: [mlir][dataflow] Use successor.isParent to replace successor.getSuccessor (NFC) (#174615)

When we check the condition. To make the code logic clearer, use
successor.isParent to replace successor.getSuccessor.

Added: 
    

Modified: 
    mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
    mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp b/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
index 062bc5ea22d17..7648d8ab4b532 100644
--- a/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
+++ b/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
@@ -514,9 +514,9 @@ void DeadCodeAnalysis::visitRegionBranchEdges(
   for (const RegionSuccessor &successor : successors) {
     // The successor can be either an entry block or the parent operation.
     ProgramPoint *point =
-        successor.getSuccessor()
-            ? getProgramPointBefore(&successor.getSuccessor()->front())
-            : getProgramPointAfter(regionBranchOp);
+        successor.isParent()
+            ? getProgramPointAfter(regionBranchOp)
+            : getProgramPointBefore(&successor.getSuccessor()->front());
 
     // Mark the entry block as executable.
     auto *state = getOrCreate<Executable>(point);

diff  --git a/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp b/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
index 7a7a58384fbb8..232bf14827556 100644
--- a/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
+++ b/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
@@ -373,7 +373,7 @@ struct TestNextAccessPass
       SmallVector<RegionSuccessor> regionSuccessors;
       iface.getSuccessorRegions(RegionBranchPoint::parent(), regionSuccessors);
       for (const RegionSuccessor &successor : regionSuccessors) {
-        if (!successor.getSuccessor() || successor.getSuccessor()->empty())
+        if (successor.isParent() || successor.getSuccessor()->empty())
           continue;
         Block &successorBlock = successor.getSuccessor()->front();
         ProgramPoint *successorPoint =