[Mlir-commits] [llvm] [mlir] [MLIR] convert OpAsmDialectInterface using ODS (PR #171488)

[llvmlistbot at llvm.org]

================
@@ -85,6 +85,16 @@ class StaticInterfaceMethod<string desc, string retTy, string methodName,
     : InterfaceMethod<desc, retTy, methodName, args, methodBody,
                       defaultImplementation>;
 
+// This class represents a pure virtual interface method.
+class PureVirtualInterfaceMethod<string desc, string retTy, string methodName,
+                            dag args = (ins)>
+    : InterfaceMethod<desc, retTy, methodName, args>;
+
+// This class represents a interface method declaration.
+class InterfaceMethodDeclaration<string desc, string retTy, string methodName,
----------------
aidint wrote:

To be honest I feel the semantic is different there. With empty body, there is a default definition that forwards to the concrete op:
https://github.com/llvm/llvm-project/blob/9a8421fa6191d2e1047e3dc8c72a22fa810f9aee/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp#L367-L371

It also doesn't imply that the method is not self-contained.

https://github.com/llvm/llvm-project/pull/171488