[Mlir-commits] [mlir] [MLIR][Python][NFC] Use enum class instead of enum (PR #174792)

[Maksim Levental]

================
@@ -330,23 +330,24 @@ class MLIR_PYTHON_API_EXPORTED PyLocation : public BaseContextObject {
   MlirLocation loc;
 };
 
-enum PyDiagnosticSeverity : std::underlying_type_t<MlirDiagnosticSeverity> {
-  MlirDiagnosticError = MlirDiagnosticError,
-  MlirDiagnosticWarning = MlirDiagnosticWarning,
-  MlirDiagnosticNote = MlirDiagnosticNote,
-  MlirDiagnosticRemark = MlirDiagnosticRemark
+enum class PyDiagnosticSeverity : std::underlying_type_t<
+    MlirDiagnosticSeverity> {
+  Error = MlirDiagnosticError,
+  Warning = MlirDiagnosticWarning,
+  Note = MlirDiagnosticNote,
+  Remark = MlirDiagnosticRemark
----------------
makslevental wrote:

can you do me a favor - can you add something like this to all of these:
```
static_assert(PyDiagnosticSeverity::Remark == MlirDiagnosticRemark, "MlirDiagnosticSeverity binding has diverged")
```
so we can catch if they ever change

https://github.com/llvm/llvm-project/pull/174792