[Mlir-commits] [mlir] [mlir][SCF] Remove `RegionBranchOpInterface` from `scf.forall` (PR #174221)

[Matthias Springer]

matthias-springer wrote:

I found additional code that misbehaves when terminators model region control flow but do not implement the `RegionBranchTerminatorOpInterface`:

```
/// Return `true` if region `r` is reachable from region `begin` according to
/// the RegionBranchOpInterface (by taking a branch).
static bool isRegionReachable(Region *begin, Region *r);
```

The above function may return "false". To be fair, I wrote that function (and the places where it is used) some time ago.


https://github.com/llvm/llvm-project/pull/174221