[Mlir-commits] [mlir] [mlir][dataflow] Use successor.isParent to replace successor.getSuccessor (NFC) (PR #174615)

[lonely eagle]

https://github.com/linuxlonelyeagle updated https://github.com/llvm/llvm-project/pull/174615

>From e1bc3d0862ca8484f218f36414ba421d53bc3dd8 Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Tue, 6 Jan 2026 16:06:57 +0000
Subject: [PATCH 1/2] use successor.isParent to replace
 successor.getSuccessor().

---
 mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp      | 2 +-
 mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp             | 6 +++---
 .../Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
index 24cb123e51877..6e5d03a0c5098 100644
--- a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
+++ b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
@@ -173,7 +173,7 @@ static void collectUnderlyingAddressValues(BlockArgument arg, unsigned maxDepth,
     RegionSuccessor regionSuccessor(region);
     bool found = false;
     for (RegionSuccessor &successor : successors) {
-      if (successor.getSuccessor() == region) {
+      if (!successor.isParent()) {
         LDBG() << "  Found matching region successor: " << successor;
         found = true;
         regionSuccessor = successor;
diff --git a/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp b/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
index 062bc5ea22d17..7648d8ab4b532 100644
--- a/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
+++ b/mlir/lib/Analysis/DataFlow/DeadCodeAnalysis.cpp
@@ -514,9 +514,9 @@ void DeadCodeAnalysis::visitRegionBranchEdges(
   for (const RegionSuccessor &successor : successors) {
     // The successor can be either an entry block or the parent operation.
     ProgramPoint *point =
-        successor.getSuccessor()
-            ? getProgramPointBefore(&successor.getSuccessor()->front())
-            : getProgramPointAfter(regionBranchOp);
+        successor.isParent()
+            ? getProgramPointAfter(regionBranchOp)
+            : getProgramPointBefore(&successor.getSuccessor()->front());
 
     // Mark the entry block as executable.
     auto *state = getOrCreate<Executable>(point);
diff --git a/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp b/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
index 7a7a58384fbb8..232bf14827556 100644
--- a/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
+++ b/mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp
@@ -373,7 +373,7 @@ struct TestNextAccessPass
       SmallVector<RegionSuccessor> regionSuccessors;
       iface.getSuccessorRegions(RegionBranchPoint::parent(), regionSuccessors);
       for (const RegionSuccessor &successor : regionSuccessors) {
-        if (!successor.getSuccessor() || successor.getSuccessor()->empty())
+        if (successor.isParent() || successor.getSuccessor()->empty())
           continue;
         Block &successorBlock = successor.getSuccessor()->front();
         ProgramPoint *successorPoint =

>From 96b929b704161c9b1e20766e5dbbf66ed65fe7cf Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Wed, 7 Jan 2026 02:00:25 +0000
Subject: [PATCH 2/2] revert change in the LocalAliasAnalysis.

---
 mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
index 6e5d03a0c5098..24cb123e51877 100644
--- a/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
+++ b/mlir/lib/Analysis/AliasAnalysis/LocalAliasAnalysis.cpp
@@ -173,7 +173,7 @@ static void collectUnderlyingAddressValues(BlockArgument arg, unsigned maxDepth,
     RegionSuccessor regionSuccessor(region);
     bool found = false;
     for (RegionSuccessor &successor : successors) {
-      if (!successor.isParent()) {
+      if (successor.getSuccessor() == region) {
         LDBG() << "  Found matching region successor: " << successor;
         found = true;
         regionSuccessor = successor;