[Mlir-commits] [mlir] [mlir][Analysis][NFC] Improve `RegionBranchOpInterface` API usage (PR #173983)

[Christian Ulmann]

================
@@ -115,8 +69,11 @@ mlir::getControlFlowPredecessors(Value value) {
       return std::nullopt;
     // Add the control flow predecessor operands to the work list.
     RegionSuccessor region(regionOp, regionOp->getResults());
-    SmallVector<Value> predecessorOperands = getRegionPredecessorOperands(
-        regionOp, region, opResult.getResultNumber());
+    SmallVector<Value> predecessorOperands;
+    // TODO: This assumes that there are no non-forwarded op results in front
+    // of the forwarded op results.
----------------
Dinistro wrote:

I might lack a bit of context here. What are you referring to with "forwarded op results"?

https://github.com/llvm/llvm-project/pull/173983