[Mlir-commits] [mlir] [mlir][Utils] Add VerificationUtils for common op verification patterns - starting with verifyDynamicDimensionCount() (NFC) (PR #174336)

Nick Kreeger llvmlistbot at llvm.org
Mon Jan 5 12:56:15 PST 2026


nkreeger wrote:

> Thanks for implementing this - it will help us standarise error logging! Huge +1
> 
> I've noticed some unused methods in this PR though (e.g. `verifyRankEquals`) and some others not being used quite _enough_ (e.g. `verifyIndexCountMatchesRank`). I have the following suggestion - split this into multiple PRs (one per helper?). Next, lets make sure that every helper is used multiple times (my rule of thumb would be 3 re-uses).
> 
> Thanks again!

Ah good catch - best to do this in steps. I updated the title and broke this down to just start with verifyDynamicDimensionCount(). I'll fast follow with more helpers and other passes 😎

https://github.com/llvm/llvm-project/pull/174336


More information about the Mlir-commits mailing list