[Mlir-commits] [mlir] [mlir][Utils] Add VerificationUtils for common op verification patterns (NFC) (PR #174336)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Mon Jan 5 10:51:10 PST 2026
https://github.com/banach-space commented:
Thanks for implementing this - it will help us standarise error logging! Huge +1
I've noticed some unused methods in this PR though (e.g. `verifyRankEquals`) and some others not being used quite _enough_ (e.g. `verifyIndexCountMatchesRank`). I have the following suggestion - split this into multiple PRs (one per helper?). Next, lets make sure that every helper is used multiple times (my rule of thumb would be 3 re-uses).
Thanks again!
https://github.com/llvm/llvm-project/pull/174336
More information about the Mlir-commits
mailing list