[Mlir-commits] [mlir] [MLIR][SCFToOpenMP] Fix crash when lowering vector reductions (PR #173978)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Conversion/SCFToOpenMP/CMakeFiles/obj.MLIRSCFToOpenMP.dir/SCFToOpenMP.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Conversion/SCFToOpenMP/CMakeFiles/obj.MLIRSCFToOpenMP.dir/SCFToOpenMP.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\lib\Conversion\SCFToOpenMP -IC:\_work\llvm-project\llvm-project\mlir\lib\Conversion\SCFToOpenMP -Itools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -MD -UNDEBUG /EHs-c- /GR- -std:c++17 /showIncludes /Fotools\mlir\lib\Conversion\SCFToOpenMP\CMakeFiles\obj.MLIRSCFToOpenMP.dir\SCFToOpenMP.cpp.obj /Fdtools\mlir\lib\Conversion\SCFToOpenMP\CMakeFiles\obj.MLIRSCFToOpenMP.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Conversion\SCFToOpenMP\SCFToOpenMP.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Conversion\SCFToOpenMP\SCFToOpenMP.cpp(405,11): error: namespaces can only be defined in global or namespace scope
405 | namespace {
|           ^
C:\_work\llvm-project\llvm-project\mlir\lib\Conversion\SCFToOpenMP\SCFToOpenMP.cpp(629,15): error: expected '}'
629 | } // namespace
|               ^
C:\_work\llvm-project\llvm-project\mlir\lib\Conversion\SCFToOpenMP\SCFToOpenMP.cpp(280,73): note: to match this '{'
280 |                                                 int64_t reductionIndex) {
|                                                                         ^
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/173978