[Mlir-commits] [mlir] [mlir][memref] Add static_sizes attribute to memref.view (PR #183795)

[Aviad Cohen]

AviadCo wrote:

Thanks for the reply, I understand your concerns.

1. I believe we are missing `ValueBoundsOpInterface` for `ViewOp` (also for other memref ops like `ReinterpretCast`) - which can be add as OOB runtime check.
2. Having a pass that verifies the static checks looks acceptable? I understand we don't have to depend on "fold" like patterns that may fail - I do see the benefit of failing OOB cases even if they are "unreachable code" as it seems like some hidden compiler bug and I can't see why to allow such. 
3. Do we want to revert OOB checks like https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp#L3257 ?

https://github.com/llvm/llvm-project/pull/183795