[Mlir-commits] [mlir] [mlir][memref] Add static_sizes attribute to memref.view (PR #183795)

[Aviad Cohen]

AviadCo wrote:

> High level opinion for all memref ops: those static OOB verifications do more harm than good and hurt overall composability. They should be runtime asserts/poison, not the verifier errors.

Hey, @joker-eph @Hardcode84 
Can you explain why you say that? If we can verify OOB in compilation time, why would we want to leave it for runtime? 

Runtime Checks means:
1. Slower runtime due to those checks (or ignored due to performance)
2. Might be edge cases that wouldn't be discover - depeneds on the control flow.
3. We did encounter OOB case which would be easier to debug if the compilation failed after the wrong transformation that caused that.

Do we have a guideline which checks we would like to move to Runtime and why? I see OOB as critical issue that can be discovered in compilation time for static cases (and maybe even some dynamic cases).

https://github.com/llvm/llvm-project/pull/183795