[Mlir-commits] [mlir] [mlir][gpu] Make launch_func op use SymbolUserOpInterface (PR #173277)

[lonely eagle]

================
@@ -1381,6 +1305,86 @@ LogicalResult LaunchFuncOp::verify() {
   return success();
 }
 
+LogicalResult
+LaunchFuncOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
+  LaunchFuncOp launchOp = *this;
+  ModuleOp module = (*this)->getParentOfType<ModuleOp>();
+  // Ignore launches that are nested more or less deep than functions in the
+  // module we are currently checking.
+  if (!launchOp->getParentOp() ||
+      launchOp->getParentOp()->getParentOp() != module)
+    return success();
+
+  // Ignore launch ops with missing attributes here. The errors will be
+  // reported by the verifiers of those ops.
----------------
linuxlonelyeagle wrote:

Yes. I did this intentionally because it now triggers the gpu.func op verification first, which prevents the original error from being caught. I’ve since modified it and restored the original test case for you to review (though the naming of this test is indeed a bit confusing to me).

https://github.com/llvm/llvm-project/pull/173277