[Mlir-commits] [mlir] [mlir][LLVM] Let decomposeValue/composeValue handle aggregates (PR #183405)

[Krzysztof Drewniak]

================
@@ -359,8 +362,11 @@ struct GPUShuffleOpLowering : public ConvertOpToLLVMPattern<gpu::ShuffleOp> {
     Value dwordAlignedDstLane =
         LLVM::ShlOp::create(rewriter, loc, int32Type, selectDstLane, two);
 
-    SmallVector<Value> decomposed =
-        LLVM::decomposeValue(rewriter, loc, initShflValue, int32Type);
+    SmallVector<Value> decomposed;
+    if (failed(LLVM::decomposeValue(rewriter, loc, initShflValue, int32Type,
+                                    decomposed)))
----------------
krzysz00 wrote:

I think that's a can't-happen, I can update the error message. On the one hand, could be an unreachable, on the other hand, I don't want things to crash if someone goes and changes the underlying method.

https://github.com/llvm/llvm-project/pull/183405