[Mlir-commits] [mlir] [mlir][transforms] Fix crash in remove-dead-values when function has non-call users (PR #183655)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3485 tests passed
* 414 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Transforms/remove-dead-values.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir -remove-dead-values="canonicalize=0" -split-input-file | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir' -remove-dead-values=canonicalize=0 -split-input-file
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir:837:11: error: CHECK: expected string not found in input
# | // CHECK: func @callee(%arg0 : i32, %arg1 : i32)
# |           ^
# | <stdin>:449:33: note: scanning from here
# | module @func_with_non_call_users {
# |                                 ^
# | <stdin>:454:2: note: possible intended match here
# |  call @callee() : () -> ()
# |  ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Transforms\remove-dead-values.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |              .
# |              .
# |              .
# |            444:  return %1 : vector<1xindex> 
# |            445:  } 
# |            446: } 
# |            447:  
# |            448: // ----- 
# |            449: module @func_with_non_call_users { 
# | check:837'0                                     X~~ error: no match found
# |            450:  func.func private @callee() { 
# | check:837'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            451:  return 
# | check:837'0     ~~~~~~~~
# |            452:  } 
# | check:837'0     ~~~
# |            453:  func.func @main_func() { 
# | check:837'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            454:  call @callee() : () -> () 
# | check:837'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:837'1      ?                          possible intended match
# |            455:  return 
# | check:837'0     ~~~~~~~~
# |            456:  } 
# | check:837'0     ~~~
# |            457:  spirv.EntryPoint "GLCompute" @main_func 
# | check:837'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            458: } 
# | check:837'0     ~~
# |            459:  
# | check:837'0     ~
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/183655