[Mlir-commits] [mlir] [mlir][linalg] Upstream PackOp/UnPackOp's generateScalarImplementation. (PR #182838)

[Abhishek Varma]

================
@@ -899,6 +1031,52 @@ struct PackOpTiling
     return tilingResult.value();
   }
 
+  LogicalResult generateScalarImplementation(Operation *op, OpBuilder &builder,
+                                             Location loc,
+                                             ValueRange ivs) const {
+    auto packOp = cast<PackOp>(op);
+    assert(packOp.hasPureBufferSemantics() &&
+           "expected operation to have buffer semantics");
+    OpBuilder::InsertionGuard g(builder);
+    // The `ivs` already represent the position into the output tensor for the
----------------
Abhishek-Varma wrote:

nit
```suggestion
    // The `ivs` already represent the position into the output for the
```
or
```suggestion
    // The `ivs` already represent the position into the output buffer for the
```

https://github.com/llvm/llvm-project/pull/182838