[Mlir-commits] [mlir] [mlir][opt][RemoveDeadValues] Fix crash when processing ops with regions that don't implement RegionBranchOpInterface (PR #182711)

[Matthias Springer]

https://github.com/matthias-springer commented:

I took a brief look at this bug. I believe the general design of the branch op handling is flawed. (Or a the very least overly complex.) I would suggest to adopt a design similar https://github.com/llvm/llvm-project/pull/173505. I.e., do only the bare minimum during `remove-dead-values`: replace the operands of branch ops with `ub.poison`. Then rely on the canonicalizer to actually remove the block arguments.

https://github.com/llvm/llvm-project/pull/182711