[Mlir-commits] [mlir] [mlir] Implement indexed access op interfaces for memref, vector, gpu, nvgpu (PR #177014)

[Kunwar Grover]

================
@@ -875,6 +894,10 @@ def MemRef_DmaStartOp : MemRef_Op<"dma_start"> {
       effects.emplace_back(MemoryEffects::Read::get(), &getTagMemRefMutable(),
                            SideEffects::DefaultResource::get());
     }
+
+    void setMemrefsAndIndices(RewriterBase& rewriter,
+      Value newSrc, ValueRange newSrcIndices,
+      Value newDst, ValueRange newDstIndices);
----------------
Groverkss wrote:

Seems a bit weird... Also why does this need a rewriter? If we want to a listener to be notified, we should just mention that this does things inplace and the user should use modifyInPlace api correctly.

https://github.com/llvm/llvm-project/pull/177014