[Mlir-commits] [mlir] [mlir][linalg] Upstream PackOp/UnPackOp's generateScalarImplementation. (PR #182838)

[Han-Chung Wang]

hanhanW wrote:

> > The revision upstreams the implementation from IREE. The ops were upstreamed some time ago, and they are the remaining implementation. The core implementation is mirrored from IREE and some cleanups and style nits are fixed.
> 
> The original implementation was upstream (by @chelini) and it has been worked on since by @banach-space and his team in addition to IREE. This description seems to imply they were upstreamed from IREE and that this is completing the process, which is incorrect.
> 
> Can you clarify what is actually being upstreamed in this PR?

The implementation was done mainly by me and @chelini in IREE a few years ago. The code was purely copied from IREE, thus the description is correct to me. Note that all the implementation was started from IREE; there are no changes about `generateScalarImplementation` since e2e is working in IREE.

> 
> > Closes #128816
> > Closes #178222
> 
> I'm not sure what this PR is doing that the other two PRs weren't. Can you clarify?

The other two PRs aimed to upstream some code, but they got staled. The state of the ops have been in a weird state, so I filled the last gap. The request/issue was created by me last year, and it was a starter project for anyone who is interested in MLIR/IREE: https://github.com/iree-org/iree/issues/20030

https://github.com/llvm/llvm-project/pull/182838