[Mlir-commits] [llvm] [mlir] [mlir] Replace MLIR_ENABLE_ROCM_CONVERSIONS with LLVM_HAS_AMDGPU_TARGET (PR #182652)

[Mehdi Amini]

================
@@ -41,7 +41,7 @@ expand_template(
         "@LLVM_HAS_NVPTX_TARGET@": "0",
         "@LLVM_INCLUDE_SPIRV_TOOLS_TESTS@": "0",
         "@MLIR_ENABLE_CUDA_RUNNER@": "0",
-        "@MLIR_ENABLE_ROCM_CONVERSIONS@": "0",
+        "@LLVM_HAS_AMDGPU_TARGET@": "0",
----------------
joker-eph wrote:

Shouldn't you just remove this line here in the Bazel file?

I'm confused about:

> The main motivation for this PR is that MLIR_ENABLE_ROCM_CONVERSIONS is broken in Bazel builds which was hardcoded to 0 in the Bazel overlay, 

when you just still hard-code with 0 here.

https://github.com/llvm/llvm-project/pull/182652