[Mlir-commits] [flang] [mlir] [MLIR] Remove deprecated setting usePropertiesForAttributes (PR #182327)

[Jacques Pienaar]

================
@@ -1959,19 +1943,12 @@ void OperationFormat::genParserVariadicSegmentResolution(Operator &op,
       else
         body << "1";
     };
-    if (op.getDialect().usePropertiesForAttributes()) {
-      body << "::llvm::copy(::llvm::ArrayRef<int32_t>({";
-      llvm::interleaveComma(op.getResults(), body, interleaveFn);
-      body << formatv("}), "
-                      "result.getOrAddProperties<{0}::Properties>()."
-                      "resultSegmentSizes.begin());\n",
-                      op.getCppClassName());
-    } else {
-      body << "  result.addAttribute(\"resultSegmentSizes\", "
-           << "parser.getBuilder().getDenseI32ArrayAttr({";
-      llvm::interleaveComma(op.getResults(), body, interleaveFn);
-      body << "}));\n";
-    }
+    body << "::llvm::copy(::llvm::ArrayRef<int32_t>({";
+    llvm::interleaveComma(op.getResults(), body, interleaveFn);
+    body << formatv("}), "
----------------
jpienaar wrote:

Couple of options: use stream more:

```c++
  body << "}), result.getOrAddProperties<" << op.getCppClassName()
       << "::Properties>().resultSegmentSizes.begin());\n";
```
local variable:
```c++
  constexpr char* properties = "result.getOrAddProperties<{0}::Properties>()";
  body << "(}), " << formatv(properties, op.getCppClassName())
       << ".resultSegmentSizes.begin());\n";
```
helper method:
```c++
  body << "(}), " << getProperty(op, "resultSegmentSizes") << ".begin());\n";
```

Initially I was thinking one can do with just some spacing. But I think I'm liking the helper method one best. I think we can elide specifying variable name as its always `result`.

https://github.com/llvm/llvm-project/pull/182327