[Mlir-commits] [mlir] [mlir][vector] Generalize multi_reduction innerparallel unrolling to N dimensions (PR #182301)

[Andrzej Warzyński]

https://github.com/banach-space commented:

I've added some inline comments.

> I'll leave this open until Monday while I work on the other PRs that will be built on top of this one.

In my experience, it’s good practice to wait for all active reviewers to explicitly sign off before landing (*). I realise I’m not always able to respond as quickly as I’d like. In those situations, I’d kindly ask other reviewers to follow the documented flow
https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted

and post something along the lines of:
 
"LGTM, all comments from all reviewers have been addressed - please feel free to land."

Last but not least: I find your patches consistently well polished, and I genuinely appreciate that. My procedural requests are minor and mostly reflect the fairly high review load many LLVM reviewers are under.

Thanks again for contributing! 🙏🏻

(*) Providing timelines is another good practice, thanks!

https://github.com/llvm/llvm-project/pull/182301