[Mlir-commits] [mlir] [MLIR] Remove deprecated setting usePropertiesForAttributes (PR #182327)

[Mehdi Amini]

================
@@ -570,20 +570,14 @@ class RegisteredOperationName : public OperationName {
         return ConcreteOp::getInherentAttr(concreteOp->getContext(),
                                            concreteOp.getProperties(), name);
       }
-      // If the op does not have support for properties, we dispatch back to the
-      // dictionnary of discardable attributes for now.
-      return cast<ConcreteOp>(op)->getDiscardableAttr(name);
+      return std::nullopt;
     }
     void setInherentAttr(Operation *op, StringAttr name,
                          Attribute value) final {
       if constexpr (hasProperties) {
         auto concreteOp = cast<ConcreteOp>(op);
-        return ConcreteOp::setInherentAttr(concreteOp.getProperties(), name,
-                                           value);
+        ConcreteOp::setInherentAttr(concreteOp.getProperties(), name, value);
       }
-      // If the op does not have support for properties, we dispatch back to the
-      // dictionnary of discardable attributes for now.
-      return cast<ConcreteOp>(op)->setDiscardableAttr(name, value);
----------------
joker-eph wrote:

Added a llvm_unreachable here

https://github.com/llvm/llvm-project/pull/182327