[Mlir-commits] [mlir] [MLIR] Remove deprecated setting usePropertiesForAttributes (PR #182327)

[Jacques Pienaar]

================
@@ -4672,13 +4525,9 @@ OpOperandAdaptorEmitter::OpOperandAdaptorEmitter(
 
   std::string sizeAttrInit;
   if (op.getTrait("::mlir::OpTrait::AttrSizedOperandSegments")) {
-    if (op.getDialect().usePropertiesForAttributes())
-      sizeAttrInit =
-          formatv(adapterSegmentSizeAttrInitCodeProperties,
-                  llvm::formatv("getProperties().operandSegmentSizes"));
-    else
-      sizeAttrInit = formatv(adapterSegmentSizeAttrInitCode,
-                             emitHelper.getAttr(operandSegmentAttrName));
+    sizeAttrInit =
+        formatv(adapterSegmentSizeAttrInitCodeProperties,
+                llvm::formatv("getProperties().operandSegmentSizes"));
----------------
jpienaar wrote:

Does this nested formatv even do anything?

https://github.com/llvm/llvm-project/pull/182327